linux-kernel - Re: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware update function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150119002634.GA23278@dtor-glaptop>
Date:	Sun, 18 Jan 2015 16:26:34 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Dudley Du <dudl@...ress.com>
Cc:	jmmahler@...il.com, rydberg@...omail.se, bleung@...gle.com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device
 firmware update function support

On Fri, Jan 16, 2015 at 02:34:12PM +0800, Dudley Du wrote:
> +	/* APP_INTEGRITY row is always the last row block,
> +	 * and the row id must be 0x01ff */
> +	row_num = get_unaligned_be16(
> +			&image->records[flash_records_count - 1].row_number);
> +	if (image->records[flash_records_count - 1].flash_array_id != 0x00 &&
> +			row_num != 0x01ff) {

By the way, shouldn't this be "or" and not "and"?

> +		dev_err(dev, "%s: invalid app_integrity data.\n", __func__);
> +		return -EINVAL;
> +	}

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/