linux-kernel - RE: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware update function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN1PR06MB070FC8E3B476865011A00EED14A0@BN1PR06MB070.namprd06.prod.outlook.com>
Date:	Mon, 19 Jan 2015 01:35:33 +0000
From:	Dudley Du <dudl@...ress.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	"jmmahler@...il.com" <jmmahler@...il.com>,
	"rydberg@...omail.se" <rydberg@...omail.se>,
	"bleung@...gle.com" <bleung@...gle.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware
 update function support



> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@...il.com]
> Sent: 2015?1?19? 8:27
> To: Dudley Du
> Cc: jmmahler@...il.com; rydberg@...omail.se; bleung@...gle.com;
> linux-input@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware
> update function support
>
> On Fri, Jan 16, 2015 at 02:34:12PM +0800, Dudley Du wrote:
> > +/* APP_INTEGRITY row is always the last row block,
> > + * and the row id must be 0x01ff */
> > +row_num = get_unaligned_be16(
> > +&image->records[flash_records_count - 1].row_number);
> > +if (image->records[flash_records_count - 1].flash_array_id != 0x00 &&
> > +row_num != 0x01ff) {
>
> By the way, shouldn't this be "or" and not "and"?

It should or, thanks for the correction.

>
> > +dev_err(dev, "%s: invalid app_integrity data.\n", __func__);
> > +return -EINVAL;
> > +}
>
> Thanks.
>
> --
> Dmitry

This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/