linux-kernel - Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150119121934.GA6456@mwanda>
Date:	Mon, 19 Jan 2015 15:19:34 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Robin Schroer <sulamiification@...il.com>
Cc:	Shirish Gajera <gajerashirish@...il.com>,
	devel@...verdev.osuosl.org, kirk@...sers.ca,
	gregkh@...uxfoundation.org, daeseok.youn@...il.com,
	rusty@...tcorp.com.au, speakup@...ux-speakup.org,
	aysemelikeyurtoglu@...il.com, linux-kernel@...r.kernel.org,
	domagoj.trsan@...il.com, roxanagabriela10@...il.com,
	tapaswenipathak@...il.com, samuel.thibault@...-lyon.org,
	dilekuzulmez@...il.com, ben@...adent.org.uk,
	sasha.levin@...cle.com, chris@...-brannons.com
Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

On Sun, Jan 18, 2015 at 09:29:21AM +0100, Robin Schroer wrote:
> On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> > index e9f0c15..141abb7 100644
> > --- a/drivers/staging/speakup/main.c
> > +++ b/drivers/staging/speakup/main.c
> > @@ -422,8 +422,10 @@ static void announce_edge(struct vc_data *vc, int msg_id)
> >  {
> >  	if (spk_bleeps & 1)
> >  		bleep(spk_y);
> > -	if ((spk_bleeps & 2) && (msg_id < edge_quiet))
> > -		synth_printf("%s\n", spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> > +	if ((spk_bleeps & 2) && (msg_id < edge_quiet)) {
> > +		synth_printf("%s\n",
> > +		spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> > +	}
> >  }
> >  
> You do not actually need to add the braces as this remains a single
> statement (mnemonic: without braces the if ends at the first semicolon).
> 

In staging (and most other trees), we prefer that the curly braces be
there for multi-line indents.  It makes it more readable.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/