linux-kernel - Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150119122300.GB6456@mwanda>
Date:	Mon, 19 Jan 2015 15:23:00 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Shirish Gajera <gajerashirish@...il.com>
Cc:	w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
	samuel.thibault@...-lyon.org, gregkh@...uxfoundation.org,
	domagoj.trsan@...il.com, roxanagabriela10@...il.com,
	dilekuzulmez@...il.com, ben@...adent.org.uk,
	daeseok.youn@...il.com, sulamiification@...il.com,
	aysemelikeyurtoglu@...il.com, rusty@...tcorp.com.au,
	tapaswenipathak@...il.com, sasha.levin@...cle.com,
	speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.


Generally this patch is fine.  There were a couple places which weren't
perfect.

On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> +	if ((spk_bleeps & 2) && (msg_id < edge_quiet)) {
> +		synth_printf("%s\n",
> +		spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> +	}

This should be:

	if ((spk_bleeps & 2) && (msg_id < edge_quiet)) {
		synth_printf("%s\n",
			     spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
	}

> +#define spk_serial_tx_busy() \
> +((inb(speakup_info.port_tts + UART_LSR) & BOTH_EMPTY) != BOTH_EMPTY)

This should be:

#define spk_serial_tx_busy() \
	((inb(speakup_info.port_tts + UART_LSR) & BOTH_EMPTY) != BOTH_EMPTY)

Otherwise this patch is nice.  I'm fine with merging it as-is if people
want.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/