linux-kernel - Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Jan 2015 15:25:39 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Shirish Gajera <gajerashirish@...il.com>,
	devel@...verdev.osuosl.org, kirk@...sers.ca, rusty@...tcorp.com.au,
	gregkh@...uxfoundation.org, daeseok.youn@...il.com,
	sulamiification@...il.com, speakup@...ux-speakup.org,
	aysemelikeyurtoglu@...il.com, linux-kernel@...r.kernel.org,
	domagoj.trsan@...il.com, roxanagabriela10@...il.com,
	tapaswenipathak@...il.com, samuel.thibault@...-lyon.org,
	dilekuzulmez@...il.com, sasha.levin@...cle.com,
	chris@...-brannons.com
Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

On Sun, Jan 18, 2015 at 09:55:50AM +0000, Ben Hutchings wrote:
> On Sat, 2015-01-17 at 23:57 -0800, Shirish Gajera wrote:
> > This patch fixes the checkpatch.pl warning:
> > 
> > WARNING: line over 80 characters
> > 
> > All line over 80 characters in driver/staging/speakup/* are fixed
> [...]
> 
> It is not important to fix all such warnings.  The code seems perfectly
> readable as it is.

You can't fight checkpatch (this is why I hate when checkpatch suggests
you introduce bugs).  In the end, people will keep sending these patches
until we merge one and this patch is actually pretty good.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/