linux-kernel - Re: [PATCH] staging: dgnc: warning line over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1421777950.2724.7.camel@perches.com>
Date:	Tue, 20 Jan 2015 10:19:10 -0800
From:	Joe Perches <joe@...ches.com>
To:	Mohamed Lotfy Hammad <mohamed.lotfy.hammad@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	lidza.louina@...il.com, markh@...pro.net,
	gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org
Subject: Re: [PATCH] staging: dgnc: warning line over 80 characters

On Tue, 2015-01-20 at 16:08 +0200, Mohamed Lotfy Hammad wrote:
> This patch fixes the following checkpatch.pl warning:
> fix line over 80 characters 
[]
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
[]
> @@ -54,14 +54,14 @@ MODULE_SUPPORTED_DEVICE("dgnc");
>   * protos for this file
>   *
>   */
> -static int		dgnc_start(void);
> -static int		dgnc_finalize_board_init(struct dgnc_board *brd);
> -static void		dgnc_init_globals(void);
> -static int		dgnc_found_board(struct pci_dev *pdev, int id);
> -static void		dgnc_cleanup_board(struct dgnc_board *brd);
> -static void		dgnc_poll_handler(ulong dummy);
> -static int		dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
> -static void		dgnc_do_remap(struct dgnc_board *brd);
> +static int dgnc_start(void);
> +static int dgnc_finalize_board_init(struct dgnc_board *brd);
> +static void dgnc_init_globals(void);
> +static int dgnc_found_board(struct pci_dev *pdev, int id);
> +static void dgnc_cleanup_board(struct dgnc_board *brd);
> +static void dgnc_poll_handler(ulong dummy);
> +static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
> +static void dgnc_do_remap(struct dgnc_board *brd);

Better still would be to eventually rearrange the code
to avoid the need for static forward declarations.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/