linux-kernel - Re: [PATCH v2 3/3] asus-laptop: cleanup is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <810077082.264036.1421778036663.JavaMail.root@mail>
Date:	Tue, 20 Jan 2015 13:20:36 -0500 (EST)
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Corentin Chary <corentin.chary@...il.com>
Cc:	platform-driver-x86@...r.kernel.org,
	Darren Hart <dvhart@...radead.org>,
	acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
	LKML <linux-kernel@...r.kernel.org>, kernel@...oirfairelinux.com
Subject: Re: [PATCH v2 3/3] asus-laptop: cleanup is_visible

Hi Corentin,

> > Use the attribute indexes and concise the if statements.
> >
> Why ? I really don't see that as an improvement.

The improvement is code clarity and maintainability. I'm not use we want
to keep multiple returns and this goto thing. I think per-attribute 
if-statements are clearer.

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/