linux-kernel - Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

Open Source and information security mailing list archives

Message-ID: <1913991589.463352.1421778909585.JavaMail.open-xchange@oxbaltgw06.schlund.de>
Date:	Tue, 20 Jan 2015 19:35:09 +0100 (CET)
From:	Stefan Wahren <stefan.wahren@...e.com>
To:	mturquette@...aro.org
Cc:	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	shawn.guo@...aro.org, festevam@...il.com, harald@...ib.org,
	linux-arm-kernel@...ts.infradead.org, Marek Vasut <marex@...x.de>
Subject: Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac
 registers

Hi,

> Marek Vasut <marex@...x.de> hat am 28. Dezember 2014 um 19:30 geschrieben:
>
>
> On Sunday, December 28, 2014 at 11:26:42 AM, Stefan Wahren wrote:
> > According to i.MX23 and i.MX28 reference manual the fractional
> > clock control registers must be addressed by byte instructions.
> >
> > This patch fixes the erroneous 32-bit access to these registers
> > and extends the comment in the init functions.
> >
> > Btw the imx23 init now uses a R-M-W sequence just like imx28 init
> > to avoid any clock glitches.
> >
> > The changes has been tested only with a i.MX28 board, because i don't
> > have access to an i.MX23 board.

since i've also a i.MX23 board, i tested this patch successful.

Any conserns about it?

> >
> > Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>
>
> I don't see a problem,
>
> Reviewed-by: Marek Vasut <marex@...x.de>
>
> Best regards,
> Marek Vasut
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives