linux-kernel - Re: [PATCH] mmc: block: fix format string warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFp+=nS-vWuRpiVjxF49Dz1WZSnwOVMgin0x_dr5etswJQ@mail.gmail.com>
Date:	Wed, 21 Jan 2015 09:44:22 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Asaf Vertz <asaf.vertz@...demg.com>
Cc:	Chris Ball <chris@...ntf.net>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Ben Hutchings <ben@...adent.org.uk>,
	Joe Perches <joe@...ches.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: block: fix format string warning

On 20 January 2015 at 17:33, Asaf Vertz <asaf.vertz@...demg.com> wrote:
> Fixed the following warning (reported by cppcheck):
> [drivers/mmc/card/block.c:2149]: (warning) %d in format string (no. 1)
> requires 'int' but the argument type is 'unsigned int'.
>
> Signed-off-by: Asaf Vertz <asaf.vertz@...demg.com>

Thanks! Applied for next.

Kind regards
Uffe

> ---
>  drivers/mmc/card/block.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 4409d79..8e1a60e 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -2147,7 +2147,7 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
>          */
>
>         snprintf(md->disk->disk_name, sizeof(md->disk->disk_name),
> -                "mmcblk%d%s", md->name_idx, subname ? subname : "");
> +                "mmcblk%u%s", md->name_idx, subname ? subname : "");
>
>         if (mmc_card_mmc(card))
>                 blk_queue_logical_block_size(md->queue.queue,
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/