linux-kernel - [PATCH] mmc: sdhci: host: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Jan 2015 19:19:45 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Vincent Yang <vincent.yang.fujitsu@...il.com>
Cc:	kbuild-all@...org, Ulf Hansson <ulf.hansson@...aro.org>,
	Andy Green <andy.green@...aro.org>,
	Tetsuya Takinishi <t.takinishi@...fujitsu.com>,
	Chris Ball <chris@...ntf.net>, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings

drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Vincent Yang <vincent.yang.fujitsu@...il.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 sdhci_f_sdh30.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mmc/host/sdhci_f_sdh30.c
+++ b/drivers/mmc/host/sdhci_f_sdh30.c
@@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct pl
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	host->ioaddr = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(host->ioaddr)) {
-		ret = PTR_ERR(host);
+		ret = PTR_ERR(host->ioaddr);
 		goto err;
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/