linux-kernel - Re: [PATCH 2/2] drivers/hwmon/adc128d818.c: Do proper sign extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54C184D0.6080509@roeck-us.net>
Date:	Thu, 22 Jan 2015 15:16:32 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Jean Delvare <jdelvare@...e.de>
CC:	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drivers/hwmon/adc128d818.c: Do proper sign extension

On 01/22/2015 02:44 PM, Rasmus Villemoes wrote:
> data->temp[index] has type s16. Because of C's promotion rules,
> (data->temp[index] << 7) >> 7 is exactly the same as
> data->temp[index]. The intention was to use bit 8 as a sign bit, so do
> that using the existing API.
>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---

Applied.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/