linux-kernel - Re: [PATCH] mm/slub: suppress BUG messages for kmem_cache_alloc/kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1501221518020.27807@chino.kir.corp.google.com>
Date:	Thu, 22 Jan 2015 15:19:18 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Andrey Skvortsov <andrej.skvortzov@...il.com>
cc:	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Christoph Lameter <cl@...ux.com>,
	Pekka Enberg <penberg@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/slub: suppress BUG messages for
 kmem_cache_alloc/kmem_cache_free

On Thu, 22 Jan 2015, Andrey Skvortsov wrote:

> diff --git a/mm/slub.c b/mm/slub.c
> index ceee1d7..6bcd031 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2404,7 +2404,7 @@ redo:
>  	 */
>  	do {
>  		tid = this_cpu_read(s->cpu_slab->tid);
> -		c = this_cpu_ptr(s->cpu_slab);
> +		c = raw_cpu_ptr(s->cpu_slab);
>  	} while (IS_ENABLED(CONFIG_PREEMPT) && unlikely(tid != c->tid));
>  
>  	/*
> @@ -2670,7 +2670,7 @@ redo:
>  	 */
>  	do {
>  		tid = this_cpu_read(s->cpu_slab->tid);
> -		c = this_cpu_ptr(s->cpu_slab);
> +		c = raw_cpu_ptr(s->cpu_slab);
>  	} while (IS_ENABLED(CONFIG_PREEMPT) && unlikely(tid != c->tid));
>  
>  	/* Same with comment on barrier() in slab_alloc_node() */

This should already be fixed with 
http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-optimize-alloc-free-fastpath-by-removing-preemption-on-off-v3.patch

You can find the latest mmotm, which was just released, at 
http://ozlabs.org/~akpm/mmotm and it should be in linux-next tomorrow.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/