linux-kernel - Re: [PATCH] mm/slub: suppress BUG messages for kmem_cache_alloc/kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150123065834.GI25900@localhost.localdomain>
Date:	Fri, 23 Jan 2015 09:58:34 +0300
From:	Andrey Skvortsov <andrej.skvortzov@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Christoph Lameter <cl@...ux.com>,
	Pekka Enberg <penberg@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/slub: suppress BUG messages for
 kmem_cache_alloc/kmem_cache_free

On Thu, Jan 22, 2015 at 03:19:18PM -0800, David Rientjes wrote:
> On Thu, 22 Jan 2015, Andrey Skvortsov wrote:
> 
> > diff --git a/mm/slub.c b/mm/slub.c
> > index ceee1d7..6bcd031 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -2404,7 +2404,7 @@ redo:
> >  	 */
> >  	do {
> >  		tid = this_cpu_read(s->cpu_slab->tid);
> > -		c = this_cpu_ptr(s->cpu_slab);
> > +		c = raw_cpu_ptr(s->cpu_slab);
> >  	} while (IS_ENABLED(CONFIG_PREEMPT) && unlikely(tid != c->tid));
> >  
> >  	/*
> > @@ -2670,7 +2670,7 @@ redo:
> >  	 */
> >  	do {
> >  		tid = this_cpu_read(s->cpu_slab->tid);
> > -		c = this_cpu_ptr(s->cpu_slab);
> > +		c = raw_cpu_ptr(s->cpu_slab);
> >  	} while (IS_ENABLED(CONFIG_PREEMPT) && unlikely(tid != c->tid));
> >  
> >  	/* Same with comment on barrier() in slab_alloc_node() */
> 
> This should already be fixed with 
> http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-optimize-alloc-free-fastpath-by-removing-preemption-on-off-v3.patch

> You can find the latest mmotm, which was just released, at 
> http://ozlabs.org/~akpm/mmotm and it should be in linux-next tomorrow.
ok. I've just looked at linux-next/master and
linux-next/akpm branches and that was not fixed there. Thanks for the
link. I'll look there in the future for mm-related patches posting a
new one.

-- 
Best regards,
Andrey Skvortsov

Secure eMail with gnupg: See http://www.gnupg.org/
PGP Key ID: 0x57A3AEAD

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)