linux-kernel - Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJhHMCB+5Qkyfpkvrgi5+DVyc2O3HJ1VVmBXEs_ETw1rst0OZA@mail.gmail.com>
Date:	Thu, 22 Jan 2015 23:03:34 -0500
From:	Pranith Kumar <bobby.prani@...il.com>
To:	Stewart Smith <stewart@...ux.vnet.ibm.com>
Cc:	Michael Ellerman <mpe@...erman.id.au>,
	Rob Herring <robh@...nel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Vasant Hegde <hegdevasant@...ux.vnet.ibm.com>,
	Paul Mackerras <paulus@...ba.org>,
	Joel Stanley <joel@....id.au>,
	Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>,
	Neelesh Gupta <neelegup@...ux.vnet.ibm.com>,
	"open list:LINUX FOR POWERPC..." <linuxppc-dev@...ts.ozlabs.org>,
	Anton Blanchard <anton@...ba.org>
Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith
<stewart@...ux.vnet.ibm.com> wrote:
> Pranith Kumar <bobby.prani@...il.com> writes:
>> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@...erman.id.au> wrote:
>>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
>>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
>>>> return 0. Check for these return values and skip registering the dump buffer.
>>>>
>>>> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>
>>>> CC: Michael Ellerman <mpe@...erman.id.au>
>>>> ---
>>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>
>>> What changed since v1? I don't see anything?
>>>
>>
>> Nothing in this patch but there is a v2 of the first patch in this
>> series, so had to resend this patch with a v2.
>
> You also missed my Reviewed-by :)
>

Sincere apologies for the oversight. Maintainers, could you please add
this Reviewed-by tag when picking this up?

Reviewed-by: Stewart Smith <stewart@...ux.vnet.ibm.com>

Thanks!

-- 
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/