linux-kernel - Re: [PATCH] Staging: dgnc: dgnc_cls.h: fixed four coding style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150124092947.GO6456@mwanda>
Date:	Sat, 24 Jan 2015 12:29:47 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sakshi Bansal <sakshi.april5@...il.com>
Cc:	lidza.louina@...il.com, gregkh@...uxfoundation.org,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: dgnc: dgnc_cls.h: fixed four coding style
 warnings

On Sat, Jan 24, 2015 at 10:49:08AM +0530, Sakshi Bansal wrote:
> Fixed 80 line warning in the code comments.
> 
> Signed-off-by: Sakshi Bansal <sakshi.april5@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.h | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
> index 465d79a..7444b00 100644
> --- a/drivers/staging/dgnc/dgnc_cls.h
> +++ b/drivers/staging/dgnc/dgnc_cls.h
> @@ -38,7 +38,8 @@
>  struct cls_uart_struct {
>  	u8 txrx;		/* WR  RHR/THR - Holding Reg */
>  	u8 ier;		/* WR  IER - Interrupt Enable Reg */
> -	u8 isr_fcr;		/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> +	u8 isr_fcr;		/* WR  ISR/FCR - Interrupt Status Reg/Fifo
> +				   Control Reg */

These aren't correct kernel style.  To be honest the original looks fine
with me.  (No one cares about checkpatch except if it makes the code
better for human beings).

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/