linux-kernel - Re: [PATCH] cgroup: Initialize root in cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1422380796.6710.13.camel@j-VirtualBox>
Date:	Tue, 27 Jan 2015 09:46:36 -0800
From:	Jason Low <jason.low2@...com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Li Zefan <lizefan@...wei.com>, linux-kernel@...r.kernel.org,
	aswin@...com, jason.low2@...com
Subject: Re: [PATCH] cgroup: Initialize root in cgroup_mount

On Tue, 2015-01-27 at 11:10 -0500, Tejun Heo wrote:
> On Mon, Jan 26, 2015 at 04:21:39PM -0800, Jason Low wrote:
> > Compiling kernel/ causes warnings:
> > 
> >     ... ‘root’ may be used uninitialized in this function
> >     ... ‘root’ was declared here
> > 
> > This isn't an issue since there is already logic to not use
> > root if we goto out_unlock without setting root.
> > 
> > Explicitly initialize root to NULL to suppress this so that we can
> > focus on catching warnings that can potentially cause bigger issues.
> 
> Which complier are you using?

Hi Tejun, one of the versions I am seeing this on is gcc 4.6.3.

>   The variable, AFAICS, is always set
> before being deref'd and the function hasn't triggered spurious
> warnings for quite a while with differing versions of gcc.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/