linux-kernel - Re: [PATCH] cgroup: Initialize root in cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150127181805.GD12314@htj.dyndns.org>
Date:	Tue, 27 Jan 2015 13:18:05 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Jason Low <jason.low2@...com>
Cc:	Li Zefan <lizefan@...wei.com>, linux-kernel@...r.kernel.org,
	aswin@...com
Subject: Re: [PATCH] cgroup: Initialize root in cgroup_mount

On Tue, Jan 27, 2015 at 09:46:36AM -0800, Jason Low wrote:
> On Tue, 2015-01-27 at 11:10 -0500, Tejun Heo wrote:
> > On Mon, Jan 26, 2015 at 04:21:39PM -0800, Jason Low wrote:
> > > Compiling kernel/ causes warnings:
> > > 
> > >     ... ‘root’ may be used uninitialized in this function
> > >     ... ‘root’ was declared here
> > > 
> > > This isn't an issue since there is already logic to not use
> > > root if we goto out_unlock without setting root.
> > > 
> > > Explicitly initialize root to NULL to suppress this so that we can
> > > focus on catching warnings that can potentially cause bigger issues.
> > 
> > Which complier are you using?
> 
> Hi Tejun, one of the versions I am seeing this on is gcc 4.6.3.

Can you plesae try something newer?  gcc for a while had trouble with
these spurious warnings.  4.6.2 is 3+ years old now.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/