linux-kernel - Re: [PATCH v3 2/6] KVM: nVMX: Enable nested virtualize x2apic mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54C89044.2090104@redhat.com>
Date:	Wed, 28 Jan 2015 08:31:16 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Wincy Van <fanwenyi0529@...il.com>
CC:	"gleb@...nel.org" <gleb@...nel.org>,
	"Zhang, Yang Z" <yang.z.zhang@...el.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Wanpeng Li <wanpeng.li@...ux.intel.com>,
	Jan Kiszka <jan.kiszka@....de>
Subject: Re: [PATCH v3 2/6] KVM: nVMX: Enable nested virtualize x2apic mode.



On 28/01/2015 07:19, Wincy Van wrote:
>> >
>> > No need for this function and nested_cpu_has_virt_x2apic_mode.  Just
>> > inline them in their caller(s).  Same for other cases throughout the series.
>> >
> Do you mean that we should also inline the same functions in the other
> patches of this patch set?
> I think these functions will keep the code tidy, just like the
> functions as nested_cpu_has_preemption_timer, nested_cpu_has_ept, etc.

Most of the functions are just used once.  If you want to keep them,
please place them all close to the existing ones.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/