linux-kernel - Re: [PATCH 2/2] blk-mq: release mq's kobjects in blk_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54CA2C59.2090607@sandisk.com>
Date:	Thu, 29 Jan 2015 13:49:29 +0100
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Ming Lei <ming.lei@...onical.com>, Jens Axboe <axboe@...com>,
	<linux-kernel@...r.kernel.org>
CC:	Christoph Hellwig <hch@....de>,
	Sasha Levin <sasha.levin@...cle.com>
Subject: Re: [PATCH 2/2] blk-mq: release mq's kobjects in blk_release_queue()

On 01/29/15 13:18, Ming Lei wrote:
> The kobject memory inside blk-mq hctx/ctx shouldn't have been freed
> before the kobject is released because driver core can access it freely
> before its release.
> 
> We can't do that in all ctx/hctx/mq_kobj's release handler because
> it can be run before blk_cleanup_queue().
> 
> Given mq_kobj shouldn't have been introduced, this patch simply moves
> mq's release into blk_release_queue().

Thanks for the quick respin. With these two patches applied my test
passes (SRP SCSI host removal).

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/