linux-kernel - Re: [RFC] ion:change ion_cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150128184509.GB1178@kroah.com>
Date:	Wed, 28 Jan 2015 10:45:09 -0800
From:	"'gregkh@...uxfoundation.org'" <gregkh@...uxfoundation.org>
To:	"Wang, Yalin" <Yalin.Wang@...ymobile.com>
Cc:	"'tranmanphong@...il.com'" <tranmanphong@...il.com>,
	"'fabio.estevam@...escale.com'" <fabio.estevam@...escale.com>,
	"'prime.zeng@...wei.com'" <prime.zeng@...wei.com>,
	"'devel@...verdev.osuosl.org'" <devel@...verdev.osuosl.org>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"Gao, Neil" <Neil.Gao@...ymobile.com>
Subject: Re: [RFC] ion:change ion_cma_allocate return error value

On Tue, Jan 27, 2015 at 02:04:21PM +0800, Wang, Yalin wrote:
> This patch change the error return value from -1 to -ENOMEM,
> so that userspace can get the correct errno, otherwise,
> -1 will be -EPERM, userspace will print permission deny for allocation
> failure.
> 
> Signed-off-by: Yalin Wang <yalin.wang@...ymobile.com>
> ---
>  drivers/staging/android/ion/ion_cma_heap.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Don't you also need to now change userspace code to properly handle
these errors?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/