linux-kernel - RE: [RFC] ion:change ion_cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35FD53F367049845BC99AC72306C23D1044A02027E01@CNBJMBX05.corpusers.net>
Date:	Thu, 29 Jan 2015 09:41:18 +0800
From:	"Wang, Yalin" <Yalin.Wang@...ymobile.com>
To:	"'gregkh@...uxfoundation.org'" <gregkh@...uxfoundation.org>
CC:	"'tranmanphong@...il.com'" <tranmanphong@...il.com>,
	"'fabio.estevam@...escale.com'" <fabio.estevam@...escale.com>,
	"'prime.zeng@...wei.com'" <prime.zeng@...wei.com>,
	"'devel@...verdev.osuosl.org'" <devel@...verdev.osuosl.org>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"Gao, Neil" <Neil.Gao@...ymobile.com>
Subject: RE: [RFC] ion:change ion_cma_allocate return error value

> -----Original Message-----
> From: 'gregkh@...uxfoundation.org' [mailto:gregkh@...uxfoundation.org]
> Sent: Thursday, January 29, 2015 2:45 AM
> To: Wang, Yalin
> Cc: 'tranmanphong@...il.com'; 'fabio.estevam@...escale.com';
> 'prime.zeng@...wei.com'; 'devel@...verdev.osuosl.org'; 'linux-
> kernel@...r.kernel.org'; Gao, Neil
> Subject: Re: [RFC] ion:change ion_cma_allocate return error value
> 
> On Tue, Jan 27, 2015 at 02:04:21PM +0800, Wang, Yalin wrote:
> > This patch change the error return value from -1 to -ENOMEM, so that
> > userspace can get the correct errno, otherwise,
> > -1 will be -EPERM, userspace will print permission deny for allocation
> > failure.
> >
> > Signed-off-by: Yalin Wang <yalin.wang@...ymobile.com>
> > ---
> >  drivers/staging/android/ion/ion_cma_heap.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> Don't you also need to now change userspace code to properly handle these
> errors?
> 
No, because userspace use strerror() to print errno,
It will print correct error string depending on kernel return
Errno.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/