linux-kernel - Re: [PATCH] arm/mm: fix compiler warning in pmdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150130100620.GL2395@suse.de>
Date:	Fri, 30 Jan 2015 10:06:20 +0000
From:	Mel Gorman <mgorman@...e.de>
To:	Andre Przywara <andre.przywara@....com>
Cc:	catalin.marinas@....com, rmk+kernel@....linux.org.uk,
	will.deacon@....com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm/mm: fix compiler warning in pmdp_invalidate() (in
 -next)

On Thu, Jan 29, 2015 at 05:48:00PM +0000, Andre Przywara wrote:
> Commit ff61d185f4e7 ("mm: convert p[te|md]_mknonnuma and remaining
> page table manipulations") removed a check in
> mm/pgtable-generic.c:pmdp_invalidate(), which leaves the
> pmd_mknotpresent macro the only user of the entry variable.
> For ARM/LPAE we use a constant 0 without referencing the argument to
> mark this condition, so the entry variable is no longer used here:
> 
> mm/pgtable-generic.c: In function 'pmdp_invalidate':
> mm/pgtable-generic.c:195:8: warning: unused variable 'entry' [-Wunused-variable]
>   pmd_t entry = *pmdp;
>         ^
> 
> Replace the ARM macro implementation with a static inline function to
> get rid of this warning.
> 
> Signed-off-by: Andre Przywara <andre.przywara@....com>

Patch looks fine to me but this is against a mmotm patch that is
included in mmotm. The commit ID is not going to last. This should be
sent to Andrew Morton with a note saying it's a fix to the mmotm patch
mm-convert-p_mknonnuma-and-remaining-page-table-manipulations.patch .
He'll then fold your fix into the original patch so that bisection works
correctly when merged to mainline. Do you mind doing that please?

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/