linux-kernel - Re: [PATCH] spi/xilinx: Fix access invalid memory on xilinx_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPybu_3W3pSBLCxnVKyPVgnFQkitYMGu=xYbX+PpeTZcQH1oXA@mail.gmail.com>
Date:	Fri, 30 Jan 2015 13:23:01 +0100
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Mark Brown <broonie@...nel.org>,
	Michal Simek <michal.simek@...inx.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	linux-spi <linux-spi@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi/xilinx: Fix access invalid memory on xilinx_spi_tx

On 30 Jan 2015 11:06, "Geert Uytterhoeven" <geert@...ux-m68k.org> wrote:

> Is this endian-safe?

As endianness safe as the original code, but there is also an issue. It is
using rx_ptr.

I am away until  Sunday. So I cannot make a new patch until then. I tried
to make this patch before leaving in the morning and was obviously a
mistake.

Again, Sorry for the mess this is really embarrassing.
Regards
>         xspi->tx_ptr += xspi->bytes_per_word;

> >  }
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> geert@...ux-m68k.org <javascript:;>
>
> In personal conversations with technical people, I call myself a hacker.
> But
> when I'm talking to journalists I just say "programmer" or something like
> that.
>                                 -- Linus Torvalds
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/