linux-kernel - Re: [Xen-devel] [PATCH 1/3] xen: mark pvscsi frontend request consumed only after last read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54CB77BF.9010300@suse.com>
Date:	Fri, 30 Jan 2015 13:23:27 +0100
From:	Juergen Gross <jgross@...e.com>
To:	Jan Beulich <JBeulich@...e.com>
CC:	david.vrabel@...rix.com,
	xen-devel <xen-devel@...ts.xenproject.org>,
	boris.ostrovsky@...cle.com, konrad.wilk@...cle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH 1/3] xen: mark pvscsi frontend request consumed
 only after last read

On 01/30/2015 12:47 PM, Jan Beulich wrote:
>>>> On 30.01.15 at 12:21, <JGross@...e.com> wrote:
>> @@ -734,11 +734,11 @@ static int scsiback_do_cmd_fn(struct vscsibk_info *info)
>>   		if (!pending_req)
>>   			return 1;
>>
>> -		ring_req = RING_GET_REQUEST(ring, rc);
>> +		memcpy(&ring_req, RING_GET_REQUEST(ring, rc), sizeof(ring_req));
>
> I'd recommend the type safe *ring_req = *RING_GET_REQUEST(ring, rc)
> here.

I think I'll use ring_req = *RING_GET_REQUEST(ring, rc) :-)

>
>>   		ring->req_cons = ++rc;
>>
>> -		act = ring_req->act;
>> -		err = prepare_pending_reqs(info, ring_req, pending_req);
>> +		act = ring_req.act;
>
> Is this helper variable then still needed?

No, you're right. Will delete it.


Juergen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/