linux-kernel - Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150130132647.GA6456@mwanda>
Date:	Fri, 30 Jan 2015 16:26:47 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Ian Abbott <abbotti@....co.uk>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	devel@...verdev.osuosl.org,
	Chase Southwood <chase.southwood@...il.com>,
	Conrad Meyer <cemeyer@...edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Fred Akers <knivey@...ops.net>
Subject: Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500:
 Change variables that is never used

The more I look at these, the more I don't like these patches.  The
original code looks like:

	foo = inb();

There is a 90% chance that we should just delete the whole line, but the
problem is that deleting the whole line is risky because sometimes
reading from the hardware has side effects.  So there is a 10% chance
that we should change to to:

	inb();

Changing it to that is safer, and that's what we are doing, but there is
a 90% chance that it is the wrong thing to do.

When we silence the warnings in the wrong way, then it makes it harder
for anyone to find the warnings and fix it in the correct way.  I also
would like to fix all the static checker warnings in the kernel, but
there is no point in just "silencing the warnings." we should need to
"fix" them.

It's frustrating that we aren't able to fix this code because we don't
have the hardware, but that's the reality.  Let's, please, leave the
warnings as-is until someone with hardware can fix them properly.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/