linux-kernel - Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150130201831.GM6507@mwanda>
Date:	Fri, 30 Jan 2015 23:18:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Ian Abbott <abbotti@....co.uk>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	devel@...verdev.osuosl.org,
	Chase Southwood <chase.southwood@...il.com>,
	Conrad Meyer <cemeyer@...edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Fred Akers <knivey@...ops.net>
Subject: Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500:
 Change variables that is never used

Richard, asked some questions out of band.

I like these patches where they can remove the whole line.  I don't like
them where they leave stray, unneeded function calls.  Or if we know
that we need the function calls then I like those.

Also when it comes to the point where we move this code out of staging
then we can look at these warnings again.  Normally people are good at
fixing up any remaining static checker warnings at the end.  (Except for
binder, obviously.  Binder didn't clean up anything.  It's maintained by
a mailing list which has yet to add itself to MAINTAINERS.  Stupid
binder mailing list).

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/