linux-kernel - Re: [PATCH 2/3] perf tools: Do not rely on dso__data_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150130135640.GC6188@krava.brq.redhat.com>
Date:	Fri, 30 Jan 2015 14:56:40 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] perf tools: Do not rely on dso__data_read_offset()
 to open dso

On Fri, Jan 30, 2015 at 11:33:28AM +0900, Namhyung Kim wrote:
> Do not rely on dso__data_read_offset() will always call dso__data_fd()
> internally.  With multi-thread support, accessing a fd will be
> protected by a lock and it'll cause a huge contention.  It can be
> avoided since we can skip reading from file if there's a data in the
> dso cache.
> 
> If one needs to call the dso__data_read_offset(), [s]he also needs to
> call dso__data_fd() (or set dso->binary_type at least) first like the
> dwarf unwind code does.

hum, I dont see the need for this, but I haven't checked your
patchset for the multithread support yet ;-)

anyway, I dont mind tp straighten up the interface:

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/