linux-kernel - Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150130211005.GN6507@mwanda>
Date:	Sat, 31 Jan 2015 00:10:05 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Ian Abbott <abbotti@....co.uk>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	devel@...verdev.osuosl.org,
	Chase Southwood <chase.southwood@...il.com>,
	Conrad Meyer <cemeyer@...edu>, linux-kernel@...r.kernel.org,
	Fred Akers <knivey@...ops.net>
Subject: Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500:
 Change variables that is never used

On Fri, Jan 30, 2015 at 12:25:53PM -0800, Greg Kroah-Hartman wrote:
> On Fri, Jan 30, 2015 at 11:18:31PM +0300, Dan Carpenter wrote:
> > Richard, asked some questions out of band.
> > 
> > I like these patches where they can remove the whole line.  I don't like
> > them where they leave stray, unneeded function calls.  Or if we know
> > that we need the function calls then I like those.
> > 
> > Also when it comes to the point where we move this code out of staging
> > then we can look at these warnings again.  Normally people are good at
> > fixing up any remaining static checker warnings at the end.  (Except for
> > binder, obviously.  Binder didn't clean up anything.  It's maintained by
> > a mailing list which has yet to add itself to MAINTAINERS.  Stupid
> > binder mailing list).
> 
> What remaining issues were in the binder code?  And I have a
> non-mailing-list MAINTAINERS entry for binder in linux-next, it will go
> to Linus in a few hours.
> 

Oh.  Hm...  I looked at it again and it's not as bad as I remember.  I
appologize.  I did have a question but I'll take it to another thread.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/