linux-kernel - Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKXHbyOGrsU6COA_R9cpjwjuCoXPpwsdsH7j9hQ50=UANxPWpQ@mail.gmail.com>
Date:	Sat, 31 Jan 2015 14:55:09 +0100
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ian Abbott <abbotti@....co.uk>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Chase Southwood <chase.southwood@...il.com>,
	Conrad Meyer <cemeyer@...edu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Fred Akers <knivey@...ops.net>
Subject: Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500:
 Change variables that is never used

2015-01-30 22:10 GMT+01:00 Dan Carpenter <dan.carpenter@...cle.com>:
> On Fri, Jan 30, 2015 at 12:25:53PM -0800, Greg Kroah-Hartman wrote:
>> On Fri, Jan 30, 2015 at 11:18:31PM +0300, Dan Carpenter wrote:
>> > Richard, asked some questions out of band.
>> >

Hi all!

As Dan said, I email him before. But it was not really meant only to
him, wrong click on the answer button on my mobile.
And really a better question to Greg, so here it is again.

Understand what you mean, although in this case it requires someone with
this HW to run a static code checking to.

But all the code in staging has a TODO file, is it not appropriate to
add the comment there then?

BTW all, ther i a PATCH v2 for this.


Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/