linux-kernel - Re: [PATCH] staging: rtl8723au: core: rtw_mlme_ext: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2015 00:16:34 +0100
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Jes Sorensen <Jes.Sorensen@...hat.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723au: core: rtw_mlme_ext: Removed variables
 that is never used

2015-02-01 23:58 GMT+01:00 Jes Sorensen <Jes.Sorensen@...hat.com>:
> Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> writes:
>> Variable was assigned a value that was never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
>> ---
>>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c |    7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
>> index 0e0f73c..7c60fed 100644
>> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
>> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
>> @@ -2515,7 +2515,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da,
>>       unsigned char *mac, *bssid;
>>       struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
>>  #ifdef CONFIG_8723AU_AP_MODE
>> -     const u8 *pwps_ie;
>>       u8 *ssid_ie;
>>       int ssid_ielen;
>>       int ssid_ielen_diff;
>> @@ -2576,7 +2575,7 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da,
>>
>>  #ifdef CONFIG_8723AU_AP_MODE
>>       if ((pmlmeinfo->state & 0x03) == MSR_AP) {
>> -             pwps_ie = cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
>> +             cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
>>                                                 WLAN_OUI_TYPE_MICROSOFT_WPS,
>>                                                 cur_network->IEs,
>>                                                 cur_network->IELength);
>
> If you want to modify this, you need to fix up the formatting to go with
> it.
>
> NACK
>

Hi

I am sorry, please ignore this.
I will not send any more patches.

Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/