linux-kernel - Re: [PATCH] staging: rtl8723au: hal: HalDMOutSrc8723A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2015 00:17:09 +0100
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Jes Sorensen <Jes.Sorensen@...hat.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Roberta Dobrescu <roberta.dobrescu@...il.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723au: hal: HalDMOutSrc8723A_CE: Removed
 variables that is never used

2015-02-02 0:00 GMT+01:00 Jes Sorensen <Jes.Sorensen@...hat.com>:
> Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> writes:
>> Variable was assigned a value that was never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
>> ---
>>  drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c |    6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c
>> index 179a1ba..3cbbfb7 100644
>> --- a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c
>> +++ b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c
>> @@ -743,10 +743,8 @@ static void _PHY_IQCalibrate(struct rtw_adapter *pAdapter, int result[][8], u8 t
>>       /*  Note: IQ calibration must be performed after loading  */
>>       /*              PHY_REG.txt , and radio_a, radio_b.txt   */
>>
>> -     u32 bbvalue;
>> -
>>       if (t == 0) {
>> -             bbvalue = PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord);
>> +             PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord);
>
> In this particular case, I'd say to get rid of the call completely.
> FPGA0_RFMOD should not have magic side effects just from being read.
>
> Jes
>
>>
>>               /*  Save ADDA parameters, turn Path A ADDA on */
>>               _PHY_SaveADDARegisters(pAdapter, ADDA_REG, pdmpriv->ADDA_backup, IQK_ADDA_REG_NUM);
>> @@ -1047,7 +1045,7 @@ void rtl8723a_phy_iq_calibrate(struct rtw_adapter *pAdapter, bool bReCovery)
>>               bPathAOK = bPathBOK = true;
>>       } else {
>>               RegE94 = RegEB4 = pdmpriv->RegE94 = pdmpriv->RegEB4 = 0x100;    /* X default value */
>> -             RegE9C = RegEBC = pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0;              /* Y default value */
>> +             pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0;                /* Y default value */
>>       }
>>
>>       if ((RegE94 != 0)/*&&(RegEA4 != 0)*/)



Hi

I am sorry, please ignore this.
I will not send any more patches.

Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/