linux-kernel - Re: [PATCH] 3.19-rc7: add quirk for 1c28:0122 (rev 14) SATA controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2015 14:46:23 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Tim Sander <tim@...eglstein.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"alex.williamson@...hat.com" <alex.williamson@...hat.com>
Subject: Re: [PATCH] 3.19-rc7: add quirk for 1c28:0122 (rev 14) SATA controller

On Mon, Feb 2, 2015 at 2:15 PM, Tim Sander <tim@...eglstein.org> wrote:
> Hi Bjorn
>
> Am Montag 02 Februar 2015, 08:55:33 schrieb Bjorn Helgaas:
>> [+cc Alex]
>>
>> On Mon, Feb 2, 2015 at 5:29 AM, Tim Sander <tim@...eglstein.org> wrote:
>> > The long name for this device is
>> > Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)
>> >
>> > Background: the error description on bugzilla
>> > https://bugzilla.kernel.org/show_bug.cgi?id=42679
>> > inspired me to check if my brand new m4 pci ssd could work with a quirk.
>> > Its device representation is not visible before this patch.
>> > After this patch it appears as a normal device. Formatting
>> > and mounting worked so far.
>> >
>> > Signed-off-by: Tim Sander <tim@...eglstein.org>
>>
>> Hi Tim,
>>
>> Thanks a lot for the patch.  Can you open a new report at
>> http://bugzilla.kernel.org and attach the complete dmesg and "lspci
>> -vv" output without this patch, and also a dmesg log *with* this
>> patch?  I like to keep a little documentation around in case we
>> restructure this code in the future.
> Basically its the same issue as the linked bug report, so reporting this twice
> seems a little backward to me?

If you'd rather just attach the dmesg/lspci info to the existing
bugzilla, I'm OK with that.  But obviously it is a different device
than for the existing quirks, and it's always nice to have more
complete information in case it turns out that we think it's the same
problem today, but tomorrow we learn about a slightly different issue
that only seemed to be the same.

>> Also, since the vendor and device IDs are used only once, we probably
>> won't add them to pci_ids.h (see the comment at the top of the file).
>> Just use the bare constants in the quirk.
>
> Mh, thats what i had first. For patch submission i created the header entries
> as it seemed cleaner as you can deduce the manufacturer from the names.
> But then its really not that important.

It's not a big deal, and I could make that change myself.  I think the
convention is left over from a time when there were unnecessary merge
conflicts on pci_ids.h.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/