linux-kernel - Re: [PATCH] 3.19-rc7: add quirk for 1c28:0122 (rev 14) SATA controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2624799.cDSRma3dVE@dabox>
Date:	Tue, 03 Feb 2015 10:27:05 +0100
From:	Tim Sander <tim@...eglstein.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"alex.williamson@...hat.com" <alex.williamson@...hat.com>
Subject: Re: [PATCH] 3.19-rc7: add quirk for 1c28:0122 (rev 14) SATA controller

Hi Bjorn

Am Montag, 2. Februar 2015, 08:55:33 schrieb Bjorn Helgaas:
> [+cc Alex]
> 
> On Mon, Feb 2, 2015 at 5:29 AM, Tim Sander <tim@...eglstein.org> wrote:
> > The long name for this device is
> > Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)
> > 
> > Background: the error description on bugzilla
> > https://bugzilla.kernel.org/show_bug.cgi?id=42679
> > inspired me to check if my brand new m4 pci ssd could work with a quirk.
> > Its device representation is not visible before this patch.
> > After this patch it appears as a normal device. Formatting
> > and mounting worked so far.
> > 
> > Signed-off-by: Tim Sander <tim@...eglstein.org>
> 
> Hi Tim,
> 
> Thanks a lot for the patch.  Can you open a new report at
> http://bugzilla.kernel.org and attach the complete dmesg and "lspci
> -vv" output without this patch, and also a dmesg log *with* this
> patch?  I like to keep a little documentation around in case we
> restructure this code in the future.
I have not opened a bugreport yet, it seems in between there has been some
change in the 3.19-rc release process which made this disk work?

I bumped the rc version while creating and testing the patch as i wanted to be 
on the latest release kernel. Maybe there has been some fix along these 
releases. Do you have an idea what fix that might be? I *think* i have been on 
3.19-rc2 and i know that it has not been working there.

<snip>

Attached a dmesg of the successful case as i fail to reproduce the 
unsuccessful part even without the patch :-/. Will investigate later.

Best regards
Tim
> > ---
> > 
> >  drivers/pci/quirks.c    | 4 ++++
> >  include/linux/pci_ids.h | 3 +++
> >  2 files changed, 7 insertions(+)
> > 
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > index e52356a..fad7383 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -3540,6 +3540,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
> > 
> >  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
> >  
> >                          PCI_DEVICE_ID_JMICRON_JMB388_ESD,
> >                          quirk_dma_func1_alias);
> > 
> > +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */
> > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
> > +                        PCI_DEVICE_ID_PLEXTOR_M6E,
> > +                        quirk_dma_func1_alias);
> > 
> >  /*
> >  
> >   * A few PCIe-to-PCI bridges fail to expose a PCIe capability, resulting
> >   in
> > 
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index e63c02a..1607b20 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2487,6 +2487,9 @@
> > 
> >  #define PCI_VENDOR_ID_ASMEDIA          0x1b21
> > 
> > +#define PCI_VENDOR_ID_LITE_ON          0x1c28
> > +#define PCI_DEVICE_ID_PLEXTOR_M6E      0x0122
> > +
> > 
> >  #define PCI_VENDOR_ID_CIRCUITCO                0x1cc8
> >  #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
> > 
> > --
> > 1.9.1

View attachment "dmesg.fail_cold" of type "text/plain" (77858 bytes)

View attachment "lspcivv" of type "text/plain" (39648 bytes)