linux-kernel - [PATCH] samples: Fix `echo 1 > /proc/int-fifo` never return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1422964277-140278-2-git-send-email-long.wanglong@huawei.com>
Date:	Tue, 3 Feb 2015 11:51:17 +0000
From:	Wang Long <long.wanglong@...wei.com>
To:	<stefani@...bold.net>
CC:	<long.wanglong@...wei.com>, <peifeiyue@...wei.com>,
	<linux-kernel@...r.kernel.org>
Subject: [PATCH] samples: Fix `echo 1 > /proc/int-fifo` never return error

echo 99 > /proc/int-fifo       ------------> Never return
echo 1000 > /proc/int-fifo     ------------> Never return

this patch fix it.

Signed-off-by: Wang Long <long.wanglong@...wei.com>
---
 samples/kfifo/inttype-example.c | 51 ++++++++++++++++++++++++++++++++---------
 1 file changed, 40 insertions(+), 11 deletions(-)

diff --git a/samples/kfifo/inttype-example.c b/samples/kfifo/inttype-example.c
index 8dc3c2e..cc0db5f 100644
--- a/samples/kfifo/inttype-example.c
+++ b/samples/kfifo/inttype-example.c
@@ -6,6 +6,7 @@
  * Released under the GPL version 2 only.
  *
  */
+#include <asm/uaccess.h>
 
 #include <linux/init.h>
 #include <linux/module.h>
@@ -23,6 +24,9 @@
 /* name of the proc entry */
 #define	PROC_FIFO	"int-fifo"
 
+/* Worst case buffer size needed for holding an integer. */
+#define PROC_NUMBUF 13
+
 /* lock for procfs read access */
 static DEFINE_MUTEX(read_lock);
 
@@ -108,33 +112,58 @@ static int __init testfunc(void)
 static ssize_t fifo_write(struct file *file, const char __user *buf,
 						size_t count, loff_t *ppos)
 {
-	int ret;
-	unsigned int copied;
+	char buffer[PROC_NUMBUF];
+	int value;
+	int err;
 
-	if (mutex_lock_interruptible(&write_lock))
-		return -ERESTARTSYS;
+	memset(buffer, 0, sizeof(buffer));
 
-	ret = kfifo_from_user(&test, buf, count, &copied);
+	if (count > sizeof(buffer) - 1)
+		count = sizeof(buffer) - 1;
+	if (copy_from_user(buffer, buf, count)) {
+		err = -EFAULT;
+		goto out;
+	}
 
-	mutex_unlock(&write_lock);
+	err = kstrtoint(strstrip(buffer), 0, &value);
+	if (err)
+		goto out;
+
+	if (kfifo_is_full(&test)) {
+		err = -EINVAL;
+		goto out;
+	}
 
-	return ret ? ret : copied;
+	if (mutex_lock_interruptible(&write_lock))
+		return -ERESTARTSYS;
+	kfifo_put(&test, value);
+	mutex_unlock(&write_lock);
+out:
+	return err < 0 ? err : count;
 }
 
 static ssize_t fifo_read(struct file *file, char __user *buf,
 						size_t count, loff_t *ppos)
 {
-	int ret;
-	unsigned int copied;
+	char buffer[PROC_NUMBUF * FIFO_SIZE];
+	int value;
+	size_t	len = 0;
+	ssize_t	ret = -1;
+
+	memset(buffer, 0, sizeof(buffer));
 
 	if (mutex_lock_interruptible(&read_lock))
 		return -ERESTARTSYS;
 
-	ret = kfifo_to_user(&test, buf, count, &copied);
+	while (!kfifo_is_empty(&test)){
+		ret = kfifo_get(&test, &value);
+		len = snprintf(buffer, sizeof(buffer), "%s%d\n", buffer, value);
+	}
 
 	mutex_unlock(&read_lock);
+	ret = copy_to_user(buf, buffer, len);
 
-	return ret ? ret : copied;
+	return ret ? ret : len;
 }
 
 static const struct file_operations fifo_fops = {
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/