linux-kernel - Re: [PATCH] pwm: Delete an unnecessary check before the function call "of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150203115755.GA15068@ulmo.nvidia.com>
Date:	Tue, 3 Feb 2015 12:57:58 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	linux-pwm@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] pwm: Delete an unnecessary check before the function
 call "of_node_put"

On Tue, Feb 03, 2015 at 11:58:29AM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 3 Feb 2015 11:54:28 +0100
> 
> The of_node_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/pwm/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 966497d..810aef3 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -192,7 +192,7 @@ static void of_pwmchip_add(struct pwm_chip *chip)
>  
>  static void of_pwmchip_remove(struct pwm_chip *chip)
>  {
> -	if (chip->dev && chip->dev->of_node)
> +	if (chip->dev)
>  		of_node_put(chip->dev->of_node);
>  }
>  

Applied, thanks.

Thierry

Content of type "application/pgp-signature" skipped