linux-kernel - Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150203124441.GK21293@sirena.org.uk>
Date:	Tue, 3 Feb 2015 12:44:41 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Manuel Lauss <manuel.lauss@...il.com>
Cc:	Bo Shen <voice.shen@...el.com>,
	Manuel Lauss <manuel.lauss@...glemail.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Richard Purdie <richard@...nedhand.com>,
	patches@...nsource.wolfsonmicro.com, linux-sound@...r.kernel.org,
	alsa-devel <alsa-devel@...a-project.org>,
	linux-arm-kernel@...ts.infradead.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote:

> +    wm8731->mclk = devm_clk_get(&spi->dev, "mclk");
> +    if (IS_ERR(wm8731->mclk)) {
> +        wm8731->mclk = NULL;
> +        dev_warn(&spi->dev, "assuming static MCLK\n");
> +    }

This is broken for both deferred probe and in the case where the clock
API genuinely returns a NULL clock.  Other than that it's the kind of
thing that we've done for some other drivers, though it's not good to
have to do this.  Check them for correct behaviour.

The coding style is also not right for the whole patch and there's a
lot of missing error checking.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)