linux-kernel - Re: [PATCH] iommu/amd: Fix amd_iommu_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150203173413.GI3702@8bytes.org>
Date:	Tue, 3 Feb 2015 18:34:13 +0100
From:	Joerg Roedel <joro@...tes.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Benjamin LaHaise <bcrl@...ck.org>, linux-aio@...ck.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH] iommu/amd: Fix amd_iommu_free_device()

Hi Peter,

On Tue, Feb 03, 2015 at 01:25:51PM +0100, Peter Zijlstra wrote:
> Subject: iommu/amd: Fix amd_iommu_free_device()
> 
> put_device_state_wait() doesn't loop on the condition and a spurious
> wakeup will have it free the device state even though there might still
> be references out to it.

Hmm, have you seen spurious wakeups happening? The wakeup only comes
from put_device_state() and only when the reference count goes to zero.
>From my understanding this should be correct, but maybe I got the API
wrong.


	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/