linux-kernel - Re: [PATCH v13 5/6] clkdev: Export clk_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfN1-dwN5nAp=VLkm6Q-9UqhGHsB2ZFhq+b238mgjVoMQ@mail.gmail.com>
Date:	Tue, 3 Feb 2015 19:35:03 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mike Turquette <mturquette@...aro.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Russell King <linux@....linux.org.uk>,
	linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v13 5/6] clkdev: Export clk_register_clkdev

On Fri, Jan 23, 2015 at 1:03 PM, Tomeu Vizoso
<tomeu.vizoso@...labora.com> wrote:
> So it can be used from modules such as clk-test.ko.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

Sorry for late answer, but this is useless.

We have to provide the way how to get the allocated clk_lookup.
Otherwise you have no way but memory leak at the ->remove() stage.

(By the way I used to have the exact patch locally, that's why
discovered the change in upsteam)

> ---
>  drivers/clk/clkdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index 901d242..29a1ab7 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -377,6 +377,7 @@ int clk_register_clkdev(struct clk *clk, const char *con_id,
>
>         return 0;
>  }
> +EXPORT_SYMBOL(clk_register_clkdev);
>
>  /**
>   * clk_register_clkdevs - register a set of clk_lookup for a struct clk
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/