linux-kernel - Re: [PATCH] staging: ft1000: fix braces warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Feb 2015 21:05:30 +0100
From:	bill <bilel.dr@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Bilel DRIRA <bilel.dr@...il.com>, marek.belisko@...il.com,
	gregkh@...uxfoundation.org, tapaswenipathak@...il.com,
	gdonald@...il.com, aybuke.147@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix braces warning

Ok,thank you, I will do that and resend the patch again.

On Tue, Feb 03, 2015 at 11:05:08AM -0800, Joe Perches wrote:
> On Tue, 2015-02-03 at 19:58 +0100, Bilel DRIRA wrote:
> > This patch fix the checkpatch.pl WARNING:
> []
> > diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> []
> > @@ -1963,11 +1948,10 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
> >  						ft1000_read_reg(dev,
> >  								FT1000_REG_MAG_DFSR);
> >  				}
> > -				if (tempword & 0x1f) {
> > +				if (tempword & 0x1f)
> >  					ft1000_copy_up_pkt(dev);
> > -				} else {
> > +				else
> >  					break;
> > -				}
> >  				cnt++;
> >  			} while (cnt < MAX_RCV_LOOP);
> >  
> 
> trivia: the logic here is generally better inverted:
> 
> 				if (!(tempword & 0x1f))
> 					break;
> 				ft1000_copy_up_pkt(dev);
> 				cnt++;
> 			} while (cnt < etc...)
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/