lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Feb 2015 21:05:50 +0100 From: Paul Bolle <pebolle@...cali.nl> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.cz> Cc: Valentin Rothberg <valentinrothberg@...il.com>, linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] [linux-next] sprd_serial: compile sprd_suspend and sprd_resume conditionally Building sprd_serial.o when CONFIG_PM_SLEEP is not defined triggers these warnings: drivers/tty/serial/sprd_serial.c:755:12: warning: ‘sprd_suspend’ defined but not used [-Wunused-function] static int sprd_suspend(struct device *dev) ^ drivers/tty/serial/sprd_serial.c:764:12: warning: ‘sprd_resume’ defined but not used [-Wunused-function] static int sprd_resume(struct device *dev) ^ Let's compile these functions only when CONFIG_PM_SLEEP is defined. Signed-off-by: Paul Bolle <pebolle@...cali.nl> --- The only reason I looked into this driver is because it landed in today's linux-next (ie, next-20150203) and depends on ARCH_SPRD. ARCH_SPRD is not yet included in linux-next. Since there was a patch submitted on lkml recently to add that symbol that's not a big deal. (That might change if that symbol doesn't make it into v3.20-rc[123] or so.) But I did compile this file while looking into this issue. Compile tested only, on x86_64, using the hacky make drivers/tty/serial/sprd_serial.o way to compile this file! drivers/tty/serial/sprd_serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c index 594b63331ef4..be3ed3f4ad60 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -752,6 +752,7 @@ static int sprd_probe(struct platform_device *pdev) return ret; } +#ifdef CONFIG_PM_SLEEP static int sprd_suspend(struct device *dev) { struct sprd_uart_port *sup = dev_get_drvdata(dev); @@ -769,6 +770,7 @@ static int sprd_resume(struct device *dev) return 0; } +#endif static SIMPLE_DEV_PM_OPS(sprd_pm_ops, sprd_suspend, sprd_resume); -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists