linux-kernel - RE: [PATCH] IB/mad: fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Feb 2015 21:00:19 +0000
From:	"Weiny, Ira" <ira.weiny@...el.com>
To:	"Weiny, Ira" <ira.weiny@...el.com>,
	"Wu, Fengguang" <fengguang.wu@...el.com>
CC:	"kbuild-all@...org" <kbuild-all@...org>,
	Roland Dreier <roland@...nel.org>,
	"Hefty, Sean" <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Yan Burman <yanb@...lanox.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] IB/mad: fix ifnullfree.cocci warnings

> >
> > drivers/infiniband/core/mad.c:2088:3-8: WARNING: NULL check before
> > freeing functions like kfree, debugfs_remove, debugfs_remove_recursive
> > or usb_free_urb is not needed. Maybe consider reorganizing relevant
> > code to avoid passing NULL values.
> >
> >  NULL check before some freeing functions is not needed.
> >
> >  Based on checkpatch warning
> >  "kfree(NULL) is safe this check is probably not required"
> >  and kfreeaddr.cocci by Julia Lawall.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> 
> 
> Signed-off-by: Ira Weiny <ira.weiny@...el.com>

Sorry this should have been:

Reviewed-by: Ira Weiny <ira.weiny@...el.com>
Tested-by: Ira Weiny <ira.weiny@...el.com>


> 
> 
> > ---
> >
> >  mad.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > --- a/drivers/infiniband/core/mad.c
> > +++ b/drivers/infiniband/core/mad.c
> > @@ -2084,8 +2084,7 @@ out:
> >  	/* Post another receive request for this QP */
> >  	if (response) {
> >  		ib_mad_post_receive_mads(qp_info, response);
> > -		if (recv)
> > -			kfree(recv);
> > +		kfree(recv);
> >  	} else
> >  		ib_mad_post_receive_mads(qp_info, recv);  }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body
> of a message to majordomo@...r.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/