linux-kernel - Re: [PATCH v2 5/6] regulator: max77843: Add max77843 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <54D177DB.3020705@samsung.com>
Date:	Wed, 04 Feb 2015 10:37:31 +0900
From:	Jaewon Kim <jaewon02.kim@...sung.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-pm@...r.kernel.org, Inki Dae <inki.dae@...sung.com>,
	SangBae Lee <sangbae90.lee@...sung.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Lee Jones <lee.jones@...aro.org>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Sebastian Reichel <sre@...nel.org>,
	Beomho Seo <beomho.seo@...sung.com>
Subject: Re: [PATCH v2 5/6] regulator: max77843: Add max77843 regulator driver

Hi Mark,

2015년 02월 04일 01:25에 Mark Brown 이(가) 쓴 글:
> On Tue, Feb 03, 2015 at 02:04:05PM +0900, Jaewon Kim wrote:
>> This patch adds new regulator driver to support max77843
>> MFD(Multi Function Device) chip`s regulators.
>> The Max77843 has two voltage regulators for USB safeout.
> This looks mostly good, a couple of very small things:
>
>> +static const struct regulator_desc max77843_supported_regulators[] = {
>> +	[MAX77843_SAFEOUT1] = {
>> +		.name		= "SAFEOUT1",
>> +		.id		= MAX77843_SAFEOUT1,
>> +		.ops		= &max77843_regulator_ops,
>> +		.of_match	= of_match_ptr("SAFEOUT1"),
>> +		.regulators_node = of_match_ptr("regulators"),
>> +		.type		= REGULATOR_VOLTAGE,
>> +		.owner		= THIS_MODULE,
>> +		.n_voltages	= MAX77843_SUPPORTED_VOLTAGE_NUM,
>> +		.volt_table	= max77843_regulator_table,
> It's better to make n_voltages be ARRAY_SIZE() for the table, that way
> there's no need to keep the define and array lined up if someone extends
> the driver.  A name like _safeout_voltage_table might be clearer too.

I will change n_voltages value to ARRAY_SIZE() instead of define.
And fix volt_table enum variable name.
Thanks to advise.

Thanks
Jaewon Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/