linux-kernel - Re: [PATCH v2] clkdev: Always allocate a struct clk and call __clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54D4F5DC.5060205@codeaurora.org>
Date:	Fri, 06 Feb 2015 09:11:56 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Mike Turquette <mturquette@...aro.org>
CC:	linux-kernel@...r.kernel.org,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Alban Browaeys <alban.browaeys@...il.com>
Subject: Re: [PATCH v2] clkdev: Always allocate a struct clk and call __clk_get()
 w/ CCF

On 02/06/15 04:34, Tomeu Vizoso wrote:
> On 02/06/2015 02:40 AM, Stephen Boyd wrote:
>
>> @@ -209,17 +205,13 @@ struct clk *clk_get_sys(const char *dev_id, const char *con_id)
>>  	if (!cl)
>>  		goto out;
>>  
>> -	if (!__clk_get(cl->clk)) {
>> +	clk = __clk_create_clk(__clk_get_hw(cl->clk), dev_id, con_id);
> We need to check for clk being an error either here or in __clk_get
> because __clk_create_clk can return -ENOMEM.

Good catch. Thanks.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/