linux-kernel - Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2675935.6VkJO9HMpc@vostro.rjw.lan>
Date:	Mon, 09 Feb 2015 00:28:35 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Quentin Lambert <lambert.quentin@...il.com>
Cc:	Pavel Machek <pavel@....cz>, Joe Perches <joe@...ches.com>,
	Ming Lei <ming.lei@...onical.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Len Brown <len.brown@...el.com>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message

On Saturday, February 07, 2015 01:24:36 PM Dan Carpenter wrote:
> Facts:
> 1) None of these four error messages will ever be printed.
>    http://lwn.net/Articles/627419/
> 2) These messages are a waste of RAM.

So this is what the changelog should be saying, not that it "fixes
checkpatch warnings".

checkpatch warnings in *existing* code are meaningless, unless they
uncover a *real* problem in it which quite arguably this one is.  But
in those cases patch changelogs should talk about the *real* problems
and they don't even need to mention checkpatch then as far as I'm
concerned.

Send this one with a better changelog and I'll apply it.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/