linux-kernel - Re: [PATCH 5/6] drivers: usb: core: hub.c: remove assignment of variables in if conditions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 08 Feb 2015 14:20:04 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Bas Peters <baspeters93@...il.com>, gregkh@...uxgoundation.org,
	stern@...land.harvard.edu
CC:	dan.j.williams@...el.com, hdegoede@...hat.com,
	sarah.a.sharp@...ux.intel.com, peter.chen@...escale.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] drivers: usb: core: hub.c: remove assignment of variables
 in if conditions.

On 2/8/2015 12:55 AM, Bas Peters wrote:

> As specified in the CodingStyle.

> Signed-off-by: Bas Peters <baspeters93@...il.com>
> ---
>   drivers/usb/core/hub.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)

> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 82983d9..9afe8b0 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -671,8 +671,8 @@ resubmit:
>   	if (hub->quiescing)
>   		return;
>
> -	if ((status = usb_submit_urb (hub->urb, GFP_ATOMIC)) != 0
> -			&& status != -ENODEV && status != -EPERM)
> +	status = usb_submit_urb (hub->urb, GFP_ATOMIC);

    checkpatch.pl should also complain about space before (.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/