linux-kernel - Re: [PATCH 2/3] drivers: usb: storage: cypress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54D7477C.7010603@cogentembedded.com>
Date:	Sun, 08 Feb 2015 14:24:44 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Bas Peters <baspeters93@...il.com>, mdharm-usb@...-eyed-alien.net,
	gregkh@...uxfoundation.org
CC:	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drivers: usb: storage: cypress_atacb.c: trivial checkpatch
 fixes

On 2/8/2015 1:42 AM, Bas Peters wrote:

> Fixes errors thrown by checkpatch over a space issue and the
> incorrect indentation of a switch statement.

> Signed-off-by: Bas Peters <baspeters93@...il.com>
> ---
>   drivers/usb/storage/cypress_atacb.c | 17 ++++++++---------
>   1 file changed, 8 insertions(+), 9 deletions(-)

> diff --git a/drivers/usb/storage/cypress_atacb.c b/drivers/usb/storage/cypress_atacb.c
> index 8514a2d..b3466d1 100644
> --- a/drivers/usb/storage/cypress_atacb.c
> +++ b/drivers/usb/storage/cypress_atacb.c
> @@ -96,13 +96,13 @@ static void cypress_atacb_passthrough(struct scsi_cmnd *srb, struct us_data *us)
>   	if (save_cmnd[1] >> 5) /* MULTIPLE_COUNT */
>   		goto invalid_fld;
>   	/* check protocol */
> -	switch((save_cmnd[1] >> 1) & 0xf) {
> -		case 3: /*no DATA */
> -		case 4: /* PIO in */
> -		case 5: /* PIO out */
> -			break;
> -		default:
> -			goto invalid_fld;
> +	switch ((save_cmnd[1] >> 1) & 0xf) {
> +	case 3: /*no DATA */

    Could also add space after /*, while at it.

> +	case 4: /* PIO in */
> +	case 5: /* PIO out */
> +		break;
> +	default:
> +		goto invalid_fld;
>   	}
>
>   	/* first build the ATACB command */
[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/