linux-kernel - Re: [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 08 Feb 2015 12:04:34 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Hartmut Knaack <knaack.h@....de>
CC:	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Josef Gajdusek <atx@...lax.net>,
	Teodora Baluta <teodora.baluta@...el.com>,
	Marek Belisko <marek@...delico.com>, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: magnetometer: hmc5843_core: Change type
 in printf format string

On 27/01/15 22:21, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
This one is fixed to I'm afraid.  Very bad luck on timing as 2 weeks ago you'd have
been first to post a patch for it.
> ---
>  drivers/staging/iio/magnetometer/hmc5843_core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_core.c b/drivers/staging/iio/magnetometer/hmc5843_core.c
> index fd171d8..cd049bb 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_core.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_core.c
> @@ -217,7 +217,7 @@ static ssize_t hmc5843_show_measurement_configuration(struct device *dev,
>  		return ret;
>  	val &= HMC5843_MEAS_CONF_MASK;
>  
> -	return sprintf(buf, "%d\n", val);
> +	return sprintf(buf, "%u\n", val);
>  }
>  
>  static ssize_t hmc5843_set_measurement_configuration(struct device *dev,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/