linux-kernel - Re: [PATCH] staging: iio: resolver: ad2s1210: Change type in printf format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54D75154.4000904@kernel.org>
Date:	Sun, 08 Feb 2015 12:06:44 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>
CC:	Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: resolver: ad2s1210: Change type in printf
 format string

On 27/01/15 22:22, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Finally one I don't already have a fix in place for!
Applied to the togreg branch of iio.git.
Note this will first get pushed out as staging when I get a few minutes at
home (no sign of my plane yet that was meant to leave an hour ago...)
> ---
>  drivers/staging/iio/resolver/ad2s1210.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index b4c14ba..a8ecf87 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -198,7 +198,7 @@ static ssize_t ad2s1210_show_fclkin(struct device *dev,
>  {
>  	struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev));
>  
> -	return sprintf(buf, "%d\n", st->fclkin);
> +	return sprintf(buf, "%u\n", st->fclkin);
>  }
>  
>  static ssize_t ad2s1210_store_fclkin(struct device *dev,
> @@ -237,7 +237,7 @@ static ssize_t ad2s1210_show_fexcit(struct device *dev,
>  {
>  	struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev));
>  
> -	return sprintf(buf, "%d\n", st->fexcit);
> +	return sprintf(buf, "%u\n", st->fexcit);
>  }
>  
>  static ssize_t ad2s1210_store_fexcit(struct device *dev,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/