| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <pan.2015.02.08.12.18.33@googlemail.com> Date: Sun, 8 Feb 2015 12:18:33 +0000 (UTC) From: Holger Hoffstätte <holger.hoffstaette@...glemail.com> To: linux-kernel@...r.kernel.org Subject: Re: 1e918876 breaks r8169 (linux-3.18+) On Fri, 06 Feb 2015 15:04:50 +0100, Tomas Szepe wrote: > Unfortunately, I have to take this back. I made the conclusion too early. > The problem appears with this patch applied, too, only perhaps later and > with a different frequency pattern. +1 can confirm - I also see the stack trace in question [1] from time to time, however even under low/moderate load and more or less randomly. This also used to happen with 3.14.x, so I don't think it has anything to do woth the BQL patch pe se. I *think* - and have suspected for some time now - that this is caused by a change in TSO/GSO or other offload settings, and that some r8169 models consequently suffer occasional (or in your case frequent) hiccups. BQL and/or a qdisc doing requeues might just interfer with whatever upsets the driver or HW. I used to turn on all possible settings via ethtool, but am now back to defaults, which disables sg/tso/gso. Exactly which of these settings is the culprit remains to be seen. Holger [1] https://lkml.org/lkml/2014/12/11/65 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists