linux-kernel - Re: [PATCH v3] staging: lustre: fix coding style errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFDyS3P2Fbg4kawfs7dVOUhc71P8yC2jssjTpzGJFbdfcca1HA@mail.gmail.com>
Date:	Mon, 9 Feb 2015 19:20:30 +0200
From:	Tal Shorer <tal.shorer@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	"Drokin, Oleg" <oleg.drokin@...el.com>,
	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"Dilger, Andreas" <andreas.dilger@...el.com>,
	"<gregkh@...uxfoundation.org>" <gregkh@...uxfoundation.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"<clabbe.montjoie@...il.com>" <clabbe.montjoie@...il.com>
Subject: Re: [PATCH v3] staging: lustre: fix coding style errors

Fix the following coding style errors in
drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
1. initializing lnet_table_header (static pointer) to NULL
2. missing spaces around '='

There's a third coding style error in this file which I've chosen to
not fix for clarity's sake. It is: initializing min_watchdog_ratelimit
(static int) to 0

Signed-off-by: Tal Shorer <tal.shorer@...il.com>
---

drivers/staging/lustre/lustre/
libcfs/linux/linux-proc.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
index c539e37..acc2e10 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
@@ -65,7 +65,7 @@
#include <asm/div64.h>
#include "../tracefile.h"

-static struct ctl_table_header *lnet_table_header = NULL;
+static struct ctl_table_header *lnet_table_header;
extern char lnet_upcall[1024];
/**
  * The path of debug log dump upcall script.
@@ -308,7 +308,7 @@ static int proc_console_backoff(struct ctl_table
*table, int write,
        dummy.proc_handler = &proc_dointvec;

        if (!write) { /* read */
-               backoff= libcfs_console_backoff;
+               backoff = libcfs_console_backoff;
                rc = proc_dointvec(&dummy, write, buffer, lenp, ppos);
                return rc;
        }
--
2.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/